Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword arguments pre_callback and post_callback to optimization problems #248

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Jun 9, 2023

This PR adds the keyword arguments "pre_callback" and "post_callback" to optimization problems, which allows users to define the callbacks directly when instanciating the optimization problem.

@sblauth sblauth added the enhancement New feature or request label Jun 9, 2023
@sblauth sblauth self-assigned this Jun 9, 2023
@sblauth sblauth enabled auto-merge June 9, 2023 06:48
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #248 (acce0d0) into main (2713467) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          83       83           
  Lines        6442     6444    +2     
=======================================
+ Hits         5964     5966    +2     
  Misses        478      478           
Impacted Files Coverage Δ
...n/shape_optimization/shape_optimization_problem.py 95.04% <ø> (ø)
...logy_optimization/topology_optimization_problem.py 91.03% <ø> (ø)
...ization/optimal_control/optimal_control_problem.py 98.13% <100.00%> (ø)
cashocs/_optimization/optimization_problem.py 94.30% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sblauth sblauth merged commit 6c4f3be into main Jun 9, 2023
22 checks passed
@sblauth sblauth deleted the feature/callbacks branch June 9, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant