Raises a warning if remeshing fails due to wrong Gmsh file #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not need to use meshio anymore, instead Gmsh file is scanned directly for the number of nodes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 92.89% 92.90% +0.02%
==========================================
Files 84 84
Lines 6522 6538 +16
==========================================
+ Hits 6058 6074 +16
Misses 464 464
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, an exception is raised in the function
cashocs.io.write_out_mesh(which is used for remeshing), if the currently loaded mesh (in python) and the one defined in the Gmsh file are not compatible.The code only checks, if the number of vertices is identical. We could, in the future, also check for the number of cells. But this is more complicated and most of the time also not needed.
Closes #253