Change order of post_callback and gradient norm computation #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, post_callback will be called immediately after computing the gradient and the norm will be computed afterwards. This ensures correct norm computation, when the gradient is modified by the post_callback
Codecov Report
@@ Coverage Diff @@
## hotfix/2.0.11 #306 +/- ##
=================================================
- Coverage 92.66% 92.66% -0.00%
=================================================
Files 83 83
Lines 6441 6440 -1
=================================================
- Hits 5968 5967 -1
Misses 473 473
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Sep 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, post_callback will be called immediately after computing the gradient and the norm will be computed afterwards. This ensures correct norm computation, when the gradient is modified by the post_callback