Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Issues with PETSc 3.20 #321

Merged
merged 6 commits into from
Oct 12, 2023
Merged

FIX: Issues with PETSc 3.20 #321

merged 6 commits into from
Oct 12, 2023

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Oct 12, 2023

This PR fixes some issues when using PETSc >= 3.20 as linear algebra backend.

Most issues were coming from a suboptimal use of PETSc.Vec.aypx, replacing this with PETSc.Vec.axpby fixes these issues.
However, there is still an issue with the interpolator or fenics.PETScDMCollection, which has not yet been fixed. This issue is not yet fixed / adressed, see #320.
As soon as the issue is fixed (in FEniCS), we can remove the pin from the PETSc version.

These changes are supposed to be backwards compatible
This ensures that the workflows can run using PETSc >= 3.20.
This test has to be re-enabled as soon as possible
@sblauth sblauth added bug Something isn't working CI/CD Issues or pull requests related to CI/CD labels Oct 12, 2023
@sblauth sblauth self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #321 (a668410) into hotfix/2.0.12 (1c4b100) will increase coverage by 0.01%.
The diff coverage is 95.00%.

❗ Current head a668410 differs from pull request most recent head 77f5ccd. Consider uploading reports for the commit 77f5ccd to get more accurate results

@@                Coverage Diff                @@
##           hotfix/2.0.12     #321      +/-   ##
=================================================
+ Coverage          92.66%   92.66%   +0.01%     
=================================================
  Files                 83       83              
  Lines               6440     6445       +5     
=================================================
+ Hits                5967     5972       +5     
  Misses               473      473              
Files Coverage Δ
...cs/_optimization/optimization_algorithms/l_bfgs.py 99.40% <100.00%> (+0.01%) ⬆️
.../shape_optimization/shape_variable_abstractions.py 91.89% <100.00%> (ø)
...gy_optimization/topology_optimization_algorithm.py 87.03% <100.00%> (+0.21%) ⬆️
cashocs/space_mapping/optimal_control.py 88.66% <100.00%> (ø)
cashocs/space_mapping/shape_optimization.py 85.71% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

The tests do not need to be skipped as we - temporarily - restrict
distribution of cashocs via conda-forge to petsc<=3.19
@sblauth sblauth merged commit c59dcea into hotfix/2.0.12 Oct 12, 2023
16 of 20 checks passed
@sblauth sblauth deleted the petsc320fix branch October 12, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD Issues or pull requests related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant