Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Json output is now nicer to read for humans #331

Merged
merged 2 commits into from
Oct 25, 2023
Merged

FEAT: Json output is now nicer to read for humans #331

merged 2 commits into from
Oct 25, 2023

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Oct 17, 2023

Closes #327

@sblauth
FEAT: Make json output files human-readable
1975c04 
This is done by adding the `indent=4` keyword argument to `json.dump` calls
@sblauth sblauth added enhancement New feature or request development Development-related matters labels Oct 17, 2023
@sblauth sblauth self-assigned this Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited

Codecov Report

Merging #331 (9899245) into main (98bcb25) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          84       84           
  Lines        6604     6604           
=======================================
  Hits         6110     6110           
  Misses        494      494
Files Coverage Δ
cashocs/_cli/_convert.py 91.11% <100.00%> (ø)
cashocs/io/managers.py 96.14% <100.00%> (ø)
cashocs/space_mapping/optimal_control.py 88.66% <0.00%> (ø)
cashocs/space_mapping/shape_optimization.py 85.71% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sblauth sblauth merged commit 5865ef0 into main Oct 25, 2023
23 checks passed
@sblauth sblauth deleted the dev/human_readable_json branch October 25, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sblauth sblauth

Labels
development Development-related matters enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Development] Write json output files which are nicer to read
1 participant
@sblauth