Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fixes a bug where the mesh files were not written properly #340

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Oct 25, 2023

This PR fixes the bug mentioned in #336

Closes #336

@sblauth sblauth added the bug Something isn't working label Oct 25, 2023
@sblauth sblauth added this to the v2.1 milestone Oct 25, 2023
@sblauth sblauth self-assigned this Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #340 (f721b30) into main (9717802) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files          84       84           
  Lines        6639     6640    +1     
=======================================
+ Hits         6141     6142    +1     
  Misses        498      498           
Files Coverage Δ
cashocs/io/managers.py 96.15% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sblauth sblauth merged commit f4154f9 into main Oct 25, 2023
23 checks passed
@sblauth sblauth deleted the fix/save_mesh branch October 25, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The config parameter save_mesh only works properly when a xdmf file is saved.
1 participant