Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config file parameter "global_deformation" for the deformation #348

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Nov 9, 2023

This is set to False as default so that fenics.PETScDMCollection.create_transfer_matrix is as called as little as possible, as this function sometimes gives segfaults.

…mation

This is set to False as default so that `fenics.PETScDMCollection.create_transfer_matrix` is as called as little as possible, as this function sometimes gives segfaults.
@sblauth sblauth added the bug Something isn't working label Nov 9, 2023
@sblauth sblauth self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #348 (150e18c) into main (387b80e) will decrease coverage by 0.21%.
The diff coverage is 41.18%.

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   92.50%   92.29%   -0.21%     
==========================================
  Files          84       84              
  Lines        6640     6643       +3     
==========================================
- Hits         6142     6131      -11     
- Misses        498      512      +14     
Files Coverage Δ
cashocs/_optimization/line_search/line_search.py 96.88% <100.00%> (-3.12%) ⬇️
...n/shape_optimization/shape_optimization_problem.py 95.12% <100.00%> (+0.08%) ⬆️
cashocs/io/config.py 100.00% <ø> (ø)
cashocs/geometry/mesh_handler.py 90.00% <9.09%> (-3.82%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sblauth sblauth merged commit a52d88d into main Nov 9, 2023
23 checks passed
@sblauth sblauth deleted the dev/transfer_matrix_optional branch November 9, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant