Add compatibility for ufl 2023 and ufl_legacy #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
+ Coverage 92.29% 92.35% +0.06%
==========================================
Files 84 84
Lines 6642 6709 +67
==========================================
+ Hits 6130 6196 +66
- Misses 512 513 +1 ☔ View full report in Codecov by Sentry. |
drew-parsons
reviewed
Dec 7, 2023
|
|
||
| from cashocs import _exceptions | ||
| from cashocs import _utils | ||
| from cashocs._optimization import cost_functional | ||
|
|
||
| if TYPE_CHECKING: | ||
| try: | ||
| from ufl_legacy.core import expr as ufl_expr |
There was a problem hiding this comment.
Confirmed, the alternative import is needed here. ufl_legacy was imported as ufl above, so I first thought the alternative import is not needed here. But from ufl.core imports independently, so it would access expr from ufl 2023 instead of ufl_legacy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new ufl version and backwards support for old ufl, which is called ufl_legacy - see https://fenicsproject.discourse.group/t/announcement-ufl-legacy-and-legacy-dolfin/11583
Closes #358