Fix two bugs regarding the remeshing in cashocs #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
sblauth
commented
Dec 7, 2023
sblauth
commented
- Remeshing can now be done independently of the "Output": "save_results" configuration parameter. Closes [Bug] Remeshing requires the save_results flag to be set #353
- When using remeshing, temporary files are now deleted more thoroughly. Closes [Bug] The except hook is not set correctly for remeshing, when it fails due to a too low mesh quality #354
This commit adds a try:finally block around the solvers run method for shape optimization to catch exceptions and correctly delete the temporary remeshing directory (unless the corresponding debug configuration parameter is set).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 92.35% 92.36% +0.01%
==========================================
Files 84 84
Lines 6709 6715 +6
==========================================
+ Hits 6196 6202 +6
Misses 513 513 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.