Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Change the way the temporary files are deleted when remeshing #368

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Dec 11, 2023

This PR uses a try:except clause around the solver.run method of the optimization problem - and deletes the temporary remeshing files whenever an exception is raised in there.

This is way more convenient than having to change the sys.excepthook

@sblauth sblauth added the bug Something isn't working label Dec 11, 2023
@sblauth sblauth self-assigned this Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4317910) 92.36% compared to head (f3f7226) 92.24%.

Files Patch % Lines
...n/shape_optimization/shape_optimization_problem.py 16.67% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   92.36%   92.24%   -0.12%     
==========================================
  Files          84       84              
  Lines        6717     6713       -4     
==========================================
- Hits         6204     6192      -12     
- Misses        513      521       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sblauth sblauth merged commit be1e9ed into main Dec 11, 2023
25 checks passed
@sblauth sblauth deleted the fix/remeshing_deletion branch December 11, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant