Update to use the v2 API as v1 has been fully discontinued #6
Conversation
| * "from" -> int | ||
| * "to" -> int | ||
| * "include_lower" -> bool | ||
| * "include_upper" -> bool |
There was a problem hiding this comment.
It's unclear to me if this is the best change of API that we want in the library, but it is a direct change to the new format specified in v2. Open to suggestions!
| @@ -205,7 +207,7 @@ class Terminal(Query): | |||
| operator: Optional[str] = None | |||
| value: Optional[TValue] = None | |||
| service: str = "text" | |||
| negation: bool = False | |||
| negation: Optional[bool] = False | |||
There was a problem hiding this comment.
Ideally I think we should swap this to None as well, but I was afraid of breaking existing workflows which depend on this default. Instead I am passing negation=None in the TextQuery class super().__init__.
There was a problem hiding this comment.
Ah, I'm now seeing that this might have been a longer-standing error which was raised in another PR:
#5
|
@ncoish Thanks for this PR! I'm just coming back from vacation but I'll try to review and merge this soon. |
|
Any update on this? Would be nice to have it merged. |
|
Heyy will this be merged soon..? The client is super useful, and would be great to have ti working (again) |
|
Yes, please update this. All downstream code CI stopped working because of it. |
|
FYI: #4 (comment) |
As of today (2022-07-13), the v1 version of the RCSB search API has been fully discontinued. This PR swaps the library to use the v2 version of the API, following the migration guide detailed here.
The PR also addresses a small number of typos and bugs which are not detailed in the migration guide, but which may be related to the API change.