Fix radec/seppa conversion with OFTI sampler #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m.data_table` upon initialization.
…c to sep/PA for a given object number. Updates `data_table` in place and updates the `system.radec` and `system.seppa` arrays which track which rows are in which format
…TI` (only exists in `System` now). Uses new method from `System` to do radec/seppa conversion that will properly update `data_table` Copying observed astrometry from `data_table` now happens *after* radec/seppa conversion.
henry-ngo
requested review from
isabelangelo,
sblunt,
semaphoreP and
logan-pearce
…ged to system object
Pull Request Test Coverage Report for Build 730
💛 - Coveralls |
semaphoreP
approved these changes
Jun 8, 2019
|
Looks good to me! Thanks again @henry-ngo! I agree that the function name is long but I like that it's descriptive. |
|
I think this is definitely an improvement, thanks Henry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for Issue #108
As discussed, I remove
sampler.data_tableandsampler.input_tablein favour ofsystem.data_tableandsystem.input_table. I moved the actual radec/seppa conversion calculation to be done within thesystemobject, as I wanted it to changesystem.data_tablein place while also updating the arrayssystem.radecandsystem.seppaused to keep track of which entries are in which format. I believe these arrays are necessary in additional to thequant_typecolumn ofdata_tablebecause it sorts them by body number.Right now, these conversions are done for one body at a time since we don't do multi-planet yet. It seems like the OFTI sampler was already hard-coded for just 1 planet so I kept it that way to keep the scope of this PR only on #108. It can be made to accommodate multiple planets when we make that bigger update!