HGCA Fits #317
Merged
HGCA Fits #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add this feature into beta Pic tutorial and compare with Nielsen method. |
|
Add comments about differences in methods (e.g., inflation of error bars) |
Proper motion vs epoch plotting function
update hgca edr3 to stable vizier url
|
Just made minor changes to format test_gaia file and remove the test-generated file after the test is run. The hgca tutorial just failed in gh actions for what looks like a weird cryptic gh actions reason, so I'm going to try running the tests again. Once tests pass, I'll merge it in to v3, then merge in my arbitrary abs astrometry branch. Will be so great to have this feature in v3!!! Thanks @semaphoreP! |
sblunt
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to write test and documentation.