Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

residual #337

Merged
merged 8 commits into from
Mar 1, 2024
Merged

residual #337

merged 8 commits into from
Mar 1, 2024

Conversation

Saanikachoudhary
Copy link
Collaborator

I added the residual function. Please review.

@sblunt
Copy link
Owner

sblunt commented Jun 28, 2023

Hey Saanika! Thanks so much for implementing this (and thanks for your patience waiting for me to get around to reviewing it). Would you mind adding a unit test to make sure the residual plotting code works?

@coveralls
Copy link

coveralls commented Jun 28, 2023

Pull Request Test Coverage Report for Build 5427459356

  • 4 of 170 (2.35%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.3%) to 84.082%

Changes Missing Coverage Covered Lines Changed/Added Lines %
orbitize/plot.py 4 170 2.35%
Totals Coverage Status
Change from base Build 5425350030: -2.3%
Covered Lines: 5150
Relevant Lines: 6125

💛 - Coveralls

@sblunt sblunt changed the base branch from main to v3 January 12, 2024 01:48
@sblunt sblunt requested review from semaphoreP and removed request for sblunt February 29, 2024 21:51
@sblunt sblunt requested review from sblunt and removed request for semaphoreP March 1, 2024 21:08
@sblunt sblunt mentioned this pull request Mar 1, 2024
@sblunt sblunt merged commit 6c922f7 into v3 Mar 1, 2024
5 checks passed
@sblunt sblunt deleted the saanika/changes branch March 1, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants