Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mass and parallax 2 #69

Merged
merged 12 commits into from
Oct 18, 2018
Merged

Fix mass and parallax 2 #69

merged 12 commits into from
Oct 18, 2018

Conversation

semaphoreP
Copy link
Collaborator

Ok, I think the second try starting fresh was a lot more successful.

  • Re-implemented @sblunt's changes to system.py.
  • The results posteriors are always the same size, no matter if mass/plx are fixed.
  • Similarly, OFTI's samples are also fixed size. I think the slight increase in memory usage is negligible here.
  • MCMC now samples only the non-fixed parameters, but will return posteriors that include the fixed parameters.
  • Under this philosophy, it is up to the samplers to handle the fixed parameters gracefully (system.compute_model() requires mass and parallax as params as a result right now, since the system right now does not care about fixed parameters).
  • Also, I fixed a bug where the Ensemble Sampler wasn't using the priors (was only calling the likelihood function).

Addresses #56

@semaphoreP semaphoreP added this to the v1.0 milestone Oct 18, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 495

  • 54 of 57 (94.74%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.0%) to 85.89%

Changes Missing Coverage Covered Lines Changed/Added Lines %
orbitize/sampler.py 47 50 94.0%
Files with Coverage Reduction New Missed Lines %
orbitize/results.py 1 80.13%
orbitize/sampler.py 1 96.34%
orbitize/priors.py 1 80.58%
orbitize/init.py 2 42.11%
Totals Coverage Status
Change from base Build 480: -1.0%
Covered Lines: 627
Relevant Lines: 730

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 495

  • 54 of 57 (94.74%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.0%) to 85.89%

Changes Missing Coverage Covered Lines Changed/Added Lines %
orbitize/sampler.py 47 50 94.0%
Files with Coverage Reduction New Missed Lines %
orbitize/results.py 1 80.13%
orbitize/sampler.py 1 96.34%
orbitize/priors.py 1 80.58%
orbitize/init.py 2 42.11%
Totals Coverage Status
Change from base Build 480: -1.0%
Covered Lines: 627
Relevant Lines: 730

💛 - Coveralls

@sblunt
Copy link
Owner

sblunt commented Oct 18, 2018

Looks great, @semaphoreP. Thanks for working through all these changes.

@sblunt sblunt merged commit f581de8 into master Oct 18, 2018
@sblunt sblunt deleted the fix-mass-and-parallax-2 branch October 18, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants