Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User lowercase name for Windows library #225

Merged
merged 1 commit into from May 3, 2022

Conversation

giordano
Copy link
Contributor

@giordano giordano commented May 2, 2022

Description

Most Windows on users would have a case-insensitive filesystem, but the case is
relevant when compiling on a case-sensitive filesystem, which is usually the
case when cross-compiling with MinGW on Linux, and MinGW consistently uses
lowercase names for libraries and header files.

Motivation and Context

The change is required to be able to compile the library for Windows on a case-sensitive filesystem.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Most Windows on users would have a case-insensitive filesystem, but the case is
relevant when compiling on a case-sensitive filesystem, which is usually the
case when cross-compiling with MinGW on Linux, and MinGW consistently uses
lowercase names for libraries and header files.
Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@fbergmann fbergmann merged commit a0b3fc0 into sbmlteam:development May 3, 2022
@giordano giordano deleted the mg/windows-lowercase branch May 3, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants