64-bit Compile #20
Closed
64-bit Compile #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfinke
commented
Dec 7, 2019
| @@ -506,14 +506,14 @@ | |||
| 32C8F0ED10632AB0004AB74F /* GaplessUtilities.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GaplessUtilities.m; sourceTree = "<group>"; }; | |||
| 32CA4F630368D1EE00C91783 /* Max_Prefix.pch */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Max_Prefix.pch; sourceTree = "<group>"; }; | |||
| 8C0406480B5C582E00648158 /* nb_NO */ = {isa = PBXFileReference; lastKnownFileType = text.rtf; name = nb_NO; path = nb_NO.lproj/Credits.rtf; sourceTree = "<group>"; }; | |||
| 8C0406490B5C584000648158 /* nb_NO */ = {isa = PBXFileReference; fileEncoding = 10; lastKnownFileType = text.plist.strings; lineEnding = 0; name = nb_NO; path = nb_NO.lproj/CompactDisc.strings; sourceTree = "<group>"; }; | |||
| 8C0406490B5C584000648158 /* nb_NO */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.strings; lineEnding = 0; name = nb_NO; path = nb_NO.lproj/CompactDisc.strings; sourceTree = "<group>"; }; | |||
There was a problem hiding this comment.
There was a warning in Xcode, I hope this change is ok (didn't test and don't speak Norwegian unfortunately).
martinfinke
commented
Dec 7, 2019
| @@ -47,6 +47,24 @@ | |||
|
|
|||
| #include <wavpack/wavpack.h> | |||
|
|
|||
| using namespace APE; | |||
|
|
|||
| static TagLib::ID3v2::FrameListMap frameListMap(const TagLib::Tag* tag) | |||
There was a problem hiding this comment.
This and getFrameList should probably be moved somewhere else, and not duplicated. Also the similar addFrame function.
Closed
|
Thanks for this. Max now builds correctly for 64-bit. |
|
Glad I could help 😊 and thank you for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, I could compile Max in 64-bit. I used Xcode 11.2.1 on macOS 10.14.6.
I've committed the built Frameworks as well, because that was the most work. It's a separate commit though (12dbdd9) so you can discard that one if you don't want them. Of course it would be best to not rely on pre-built versions, so I also have a PR for the changes in AudioFrameworks: sbooth/AudioFrameworks/pull/11
I'm sorry about the premature quality of these PRs. I unfortunately don't have enough time to make it more clean. I mainly just needed a 64-bit version, and thought these changes could be a good starting point.