Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpg123 header includes seemingly using incorrect include type #207

Closed
NattyNarwhal opened this issue Mar 16, 2022 · 2 comments
Closed

mpg123 header includes seemingly using incorrect include type #207

NattyNarwhal opened this issue Mar 16, 2022 · 2 comments
Assignees

Comments

@NattyNarwhal
Copy link

After a fresh clone + build of XCFrameworks, when trying to build both SFBAudioEngine directly or the Mac SimplePlayer, there's the following error:

/Users/calvin/Library/Developer/Xcode/DerivedData/SimplePlayer-macOS-edevwanlfzmwoecqwirlxhdxzcps/Build/Products/Debug/mpg123.framework/Headers/mpg123.h:12:10: Double-quoted include "fmt123.h" in framework header, expected angle-bracketed instead

It seems the <fmt123.h> needs to be in double quotes instead. There's still a warning, but it's no longer an error. My uglo workaround is: find . -name mpg123.h -exec gsed -i 's/<fmt123.h>/"fmt123.h"/g' {} \;

@NattyNarwhal NattyNarwhal changed the title mpg123 header includes seemingly using incorrect mpg123 header includes seemingly using incorrect include type Mar 16, 2022
@sbooth sbooth self-assigned this Apr 24, 2022
@sbooth
Copy link
Owner

sbooth commented Apr 24, 2022

I believe either <mpg123/fmt123.h> or "fmt123.h" would be an improvement but I'm inclined toward the former.

@sbooth
Copy link
Owner

sbooth commented Apr 24, 2022

Should be fixed in sbooth/AudioXCFrameworks@d1f7ec1

@sbooth sbooth closed this as completed Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants