Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - sync the Commit Details #5

Open
noam-honig opened this issue Jun 17, 2018 · 9 comments
Open

Feature request - sync the Commit Details #5

noam-honig opened this issue Jun 17, 2018 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@noam-honig
Copy link

The "Revision Info" button is a bit cumbersome, as it requires me to click it - and then click on the message box that opens.

It'll be great if instead you can sync the "Commit Details" window to display the commit details as you skip back and forth in the revisions.
image

Simulate the right click on history and select "View Commit Details"
image

That way, as I browse through the revisions I can see the details without another click

sboulema added a commit that referenced this issue Jun 26, 2018
@sboulema
Copy link
Owner

No possibility to control the Commit Details window from an extension. I added a custom commit details toolwindow in the latest release.

https://github.com/sboulema/GitBlamer/releases/tag/v0.1.9

@sboulema sboulema self-assigned this Jun 26, 2018
@sboulema sboulema added the enhancement New feature or request label Jun 26, 2018
@noam-honig
Copy link
Author

Looks cool - some suggestions:
It currently shows two commits - the old and the new - it'll be enough just to show the new - but if you choose to show both then:

  1. show the new on top - the old below.
  2. Indicate which one is on the right and which one is on the left
    Add a button to go to the actual commit details (so that I can see other files?) if possible.

sboulema added a commit that referenced this issue Jun 28, 2018
@sboulema
Copy link
Owner

Suggestions have been done in the new release: https://github.com/sboulema/GitBlamer/releases/tag/v0.2.13

@noam-honig
Copy link
Author

Thanks for making some changes - I have a few more comments with regards to this feature.
When showing only one commit details you should show the "Right" one (the newer one) since that's what visual studio will show if I look at this commit details. The changes are from Red to Green - and that's the commit that represents these changes.

Also - the commit details screen should sync to the current open document. (or at least refresh with a refresh button)

@sboulema
Copy link
Owner

sboulema commented Jul 9, 2018

Fixed showing the correct commit when showing single commit details.

Can you please explain the 'sync to current document' part. Right now the screen should update on moving between revisions...

@sboulema sboulema added the question Further information is requested label Jul 9, 2018
@noam-honig
Copy link
Author

noam-honig commented Jul 9, 2018 via email

@sboulema sboulema removed the question Further information is requested label Jul 9, 2018
@sboulema
Copy link
Owner

@noam-honig
Copy link
Author

I think it still needs work:

  1. When parking on a current document - should show the last commit details (I think)
  2. When showing both left and right - right should be on top.

sboulema added a commit that referenced this issue Jul 26, 2018
@sboulema
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants