Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement functions in Releases endpoint #33

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Conversation

sboysel
Copy link
Owner

@sboysel sboysel commented Jul 15, 2018

Addresses #23

  • The structure of fredr_release_tables()is non-tabular so I opted to return a list instead of a tibble with nested objects. Might not be perfectly "tidy".
  • Functions are in separate files and have distinct doc pages. I chose this since some of the parameters change across functions.

@codecov-io
Copy link

codecov-io commented Jul 15, 2018

Codecov Report

Merging #33 into master will increase coverage by 0.57%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   99.23%   99.81%   +0.57%     
==========================================
  Files          12       21       +9     
  Lines         393      538     +145     
==========================================
+ Hits          390      537     +147     
+ Misses          3        1       -2
Impacted Files Coverage Δ
R/validation.R 99.21% <100%> (+0.13%) ⬆️
R/fredr_release_dates.R 100% <100%> (ø)
R/fredr.R 100% <100%> (+3.33%) ⬆️
R/fredr_release_sources.R 100% <100%> (ø)
R/fredr_release_related_tags.R 100% <100%> (ø)
R/fredr_releases.R 100% <100%> (ø)
R/fredr_release_tags.R 100% <100%> (ø)
R/fredr_release.R 100% <100%> (ø)
R/fredr_release_tables.R 100% <100%> (ø)
R/fredr_release_series.R 100% <100%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef13a93...becb57a. Read the comment docs.

@sboysel sboysel merged commit 10e12da into master Jul 16, 2018
@sboysel sboysel deleted the feature/endpoint-releases branch July 16, 2018 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants