Fixed immediate ping timeout on quakenet #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbp
added a commit
that referenced
this pull request
Mar 21, 2013
Fixed immediate ping timeout on quakenet
|
Your commit is all numbers. I love those ones! |
telnoratti
pushed a commit
to telnoratti/phenny
that referenced
this pull request
Apr 25, 2014
benbenben1010
pushed a commit
to benbenben1010/phenny
that referenced
this pull request
Mar 15, 2016
Fixed immediate ping timeout on quakenet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servers like e.g. irc.quakenet.org won't respond to PING requests until the user has authenticated himself. I thus suggest starting pingloop() only after the initial connection/251 has been made.