Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic_quote checks #646

Merged
merged 7 commits into from Feb 1, 2020
Merged

Remove magic_quote checks #646

merged 7 commits into from Feb 1, 2020

Conversation

salasta
Copy link
Contributor

@salasta salasta commented Jan 28, 2020

Removing all references to magic_quotes.

Description

After upgrading my installation to PHP7.4 deprecated error appeared through the webpanel's ajax popup regarding get_magic_quotes_gpc().

Motivation and Context

Currently PHP7.4 is the latest version of PHP and currently the requirements for sbpp is PHP 7.1+, which would imply 7.4 is acceptable.

Fix #635

How Has This Been Tested?

Once the changes were made, I had run through the full functionality of the webpanel. Since the changes are only made to the xajax script it won't effect anything critical.

Magic quotes havn't been a thing since PHP5.4, so the function get_magic_quotes_gpc() will always return false.
https://www.php.net/manual/en/function.get-magic-quotes-gpc.php

Screenshots (if appropriate):

null

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 7.4 compatibility (get_magic_quotes_gpc() and get_magic_quotes_runtime() deprecated warnings)
2 participants