Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pathlib support #40

Closed
abjugard opened this issue Aug 13, 2017 · 3 comments
Closed

Pathlib support #40

abjugard opened this issue Aug 13, 2017 · 3 comments

Comments

@abjugard
Copy link

abjugard commented Aug 13, 2017 •
edited

pymediainfo does not support Pathlib currently. It can be worked around by presenting the Pathlib object as a string, but since pymediainfo is all about accessing media file information it would make sense for the MediaInfo class to be able to accept a Pathlib object in its constructor.
@sbraz
Copy link
Owner

sbraz commented Aug 14, 2017

That's a good idea :) I'll fix something up as soon as I have a little time.

sbraz added a commit that referenced this issue Aug 23, 2017
@sbraz
Add pathlib paths support, fixes #40
f756222
@sbraz
Copy link
Owner

sbraz commented Aug 23, 2017

Please try the pathlib branch, it should work as expected for you.

sbraz added a commit that referenced this issue Aug 24, 2017
@sbraz
Add pathlib paths support, fixes #40
c64b318
sbraz added a commit that referenced this issue Aug 24, 2017
@sbraz
Add pathlib paths support, fixes #40
e375963
@abjugard
Copy link
Author

Indeed, works exactly as I expected it to. Thank you!

@sbraz sbraz closed this as completed in b6e1acf Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abjugard @sbraz