Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages with special characters in their names break the search results page #114

Closed
sbrl opened this issue Oct 1, 2016 · 4 comments
Closed
Labels
Area: Code It's got something to do with code bug Squash it quick! fixed It's fixed!

Comments

@sbrl
Copy link
Owner

sbrl commented Oct 1, 2016

If I include special characters in a pages name (such as é for example), it causes a nasty warning to show up if they appear in the search results:

Warning
: file_get_contents(/path/to/data/.md): failed to open stream: No such file or directory in
/path/to/root/www/index.php
on line
2294
@sbrl sbrl added bug Squash it quick! Area: Code It's got something to do with code labels Oct 1, 2016
@sbrl
Copy link
Owner Author

sbrl commented Oct 1, 2016

This needs some serious investigation. I have no idea what's going on here!

@sbrl
Copy link
Owner Author

sbrl commented Oct 11, 2016

This looks like it's related to #99, but it's not.

@sbrl
Copy link
Owner Author

sbrl commented Oct 25, 2016

Aaaaahhhhhh. I think I may have figured it out. The problem lies in the fact that the conventional string manipulation functions do not support unicode characters - so we need to use mbstring instead. It looks like a huge task!

At the very least we should use the mbstring functions from now on.

@sbrl
Copy link
Owner Author

sbrl commented Mar 18, 2018

Fixed! I've learnt a lot about utf8 whilst fixing this one.....

We'll have to comb over the rest fo the codebase to replace any remaining str_replace() calls - as it doesn't support utf8 :-(

@sbrl sbrl closed this as completed Mar 18, 2018
@sbrl sbrl added the fixed It's fixed! label Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Code It's got something to do with code bug Squash it quick! fixed It's fixed!
Projects
None yet
Development

No branches or pull requests

1 participant