Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird permissions when creating directories in save action #86

Closed
sbrl opened this issue Aug 18, 2016 · 1 comment
Closed

Weird permissions when creating directories in save action #86

sbrl opened this issue Aug 18, 2016 · 1 comment
Labels
Area: Code It's got something to do with code bug Squash it quick! fixed It's fixed!
Milestone
v0.12.1

Comments

@sbrl
Copy link
Owner

sbrl commented Aug 18, 2016 •
edited

I've just had Pepperminty Wiki create a directory with the permissions 0000. That isn't right! We should explicitly set the permissions on new directories to 0775.

Note that the execute permission is essential for listing a directory's contents.
@sbrl sbrl added bug Squash it quick! Area: Code It's got something to do with code labels Aug 18, 2016
@sbrl
Copy link
Owner Author

sbrl commented Aug 18, 2016

Found the problem! We pass null in the recursive directory creator, which set the permissions to 0000 instead of the default. We should change that.

@sbrl sbrl closed this as completed in 5dea574 Aug 18, 2016
@sbrl sbrl added the fixed It's fixed! label Aug 18, 2016
@sbrl sbrl modified the milestone: v0.12.1 Aug 19, 2016
@sbrl sbrl added fixed It's fixed! and removed fixed It's fixed! labels Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Code It's got something to do with code bug Squash it quick! fixed It's fixed!
Projects
None yet
Milestone
v0.12.1
Development

No branches or pull requests
1 participant
@sbrl