New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update F5 gene to Pypgx #39
Conversation
Thanks for this PR! Before I do a thorough review, I want to point out few things:
I will review this PR soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I know how much tedious things can get when adding a new gene to PyPGx, so great job getting this much done already in your first attempt :) Please look at my suggested changes.
Once this PR is merged, there are some additional steps to be taken. For example, we need to add reference haplotype panel from the 1000 Genomes Project for F5 for both GRCh37 and GRCh38. However, these are things that I need to take care because I have the original VCF files downloaded.
Co-authored-by: Seung-been "Steven" Lee <sbstevenlee@gmail.com>
Co-authored-by: Seung-been "Steven" Lee <sbstevenlee@gmail.com>
Co-authored-by: Seung-been "Steven" Lee <sbstevenlee@gmail.com>
Co-authored-by: Seung-been "Steven" Lee <sbstevenlee@gmail.com>
Co-authored-by: Seung-been "Steven" Lee <sbstevenlee@gmail.com>
Co-authored-by: Seung-been "Steven" Lee <sbstevenlee@gmail.com>
Co-authored-by: Seung-been "Steven" Lee <sbstevenlee@gmail.com>
Co-authored-by: Seung-been "Steven" Lee <sbstevenlee@gmail.com>
Co-authored-by: Seung-been "Steven" Lee <sbstevenlee@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! Merging this PR.
@NTNguyen13, just letting you know that I added reference haplotype panel for F5 (983abee)! Now you should be able to genotype F5 with PyPGx :) |
Hi, I found that currently Pypgx does not have some genes in PharmGKB guideline, so I want to contribute my effort into this great open-source package. I start with a 'simple' gene first: F5 only have 1 variant in PGKB, and it's a Level 1A.
As I worked on this, I found that this variant is not quite simple. The gene F5 strand has been flipped when moving up from GRCh37 to GRCh38, which makes a quite confusing case. The guideline states that the risk allele is T, but it was the reference allele in GRCh37. This was changed in GRCh38, into C as the reference allele.
I'm afraid that it may lead to some changes in representation of the diplotype: for example, for homozygous of risk allele TT in GRCh37, no variant will be called => Reference/Reference, while in GRCh38, this variant will be called, and represented as c.1601G>A/c.1601G>A diplotype.
What do you think about this case? I'm making this draft pull request so that we can discuss directly on it.
P/s: Do you have any plan to expand to MT-RNR1 gene, it also level 1A and newly published on CPIC: https://cpicpgx.org/guidelines/cpic-guideline-for-aminoglycosides-and-mt-rnr1/