New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 error doc for SPA should be index.html #2

Open

gardner opened this issue May 2, 2020 · 0 comments

gardner commented May 2, 2020

Hi,
Thanks for publishing this. I just noticed that an error doc is in the pipeline.ts here:

cra-pipeline/infra/stacks/pipeline.ts

Line 21 in 3a5d1aa

websiteErrorDocument: 'error.html',

This results in a 404 page for the error.html page when a non-existent URL is accessed like: http://pipeline-files8e6940b8-tyzn4y41xz9l.s3-website-us-east-1.amazonaws.com/non-existant.html

When hosting an SPA the error document should be set to index.html so that the JS can show a 404 (and maybe report an error to the crash logger)

The text was updated successfully, but these errors were encountered:

gardner added a commit to gardner/cra-pipeline that referenced this issue


          Update pipeline.ts

fb77426

This change addresses sbstjn#2

gardner mentioned this issue

Update pipeline.ts #3

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment