Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hook to after:aws:deploy:deploy:updateStack rather than after:deploy:deploy #33

Closed
Jaffa opened this issue May 1, 2020 · 1 comment

Comments

@Jaffa
Copy link

Jaffa commented May 1, 2020

I'm attempting to have a single source project containing both React app and serverless spec, and have sls deploy:

  1. Deploy backend resources to AWS
  2. Use serverless-stack-output to update React app with details from CloudFormation
  3. Run npm build
  4. Use serverless-s3-sync to copy the React build/ directory up to S3.

Currently both serverless-stack-output and serverless-s3-sync run off after:deploy:deploy asynchronously. I'm not sure there's a way of defining the ordering or dependency between them without writing my own plugin, but it might be sufficient to move CloudFormation stack output earlier (and S3 sync later). Alternatively, is it related to #18?

I think this could be achieved by changing after:deploy:deploy to before:deploy:finalize in index.js.

I think this is sensible to go off the AWS-specific event, given it's specifically dealing with CloudFormation.

@Jaffa
Copy link
Author

Jaffa commented May 1, 2020

Yep, the above is an issue of:

@Jaffa Jaffa closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant