Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom domain to output #6

Closed
balassy opened this issue Oct 31, 2017 · 6 comments
Closed

Add custom domain to output #6

balassy opened this issue Oct 31, 2017 · 6 comments

Comments

@balassy
Copy link

balassy commented Oct 31, 2017

As a developer using the Serverless framework with the serverless-domain-manager plugin, I would like to have the name of my custom domain appear in the output file of the serverless-stack-output plugin, so I can target my post-deployment integration tests to the custom domain, instead of the API Gateway generated ServiceEndpoint.

Thank you for creating and maintaining this plugin!

@sbstjn
Copy link
Owner

sbstjn commented Nov 2, 2017

Thanks for the issue. Basically, the plugin just takes the configured stack output and writes it to a file. You should open an issue for the serverless-domain-manager plugin to include the custom domain in the stack output. If this is implemented in the serverless-domain-manager plugin, my plugin will include the domain automatically …

@sbstjn
Copy link
Owner

sbstjn commented Nov 2, 2017

I created an issue at amplify-education/serverless-domain-manager#43 🎉

@balassy
Copy link
Author

balassy commented Nov 3, 2017

Thank you!

@kalinchernev
Copy link

Useful reply - I also came here after searching for a similar solution, but after configuring an ES.
Not too obvious from the documentation, but I guess anyone using a configuration or a plugin not providing the output will either read this guide here or read the example very carefully.

@majones-amplify
Copy link

Hi all!
I had a chance to resolve this this morning (amplify-education/serverless-domain-manager#47), the plugin should now support this functionality.
Give it a whirl and please open an issue with us if you have any problems with it.

@balassy
Copy link
Author

balassy commented Nov 11, 2017

Thank you @majones-amplify, it works well from serverless-domain-manager@1.1.18.
This issue can be closed now.

@balassy balassy closed this as completed Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants