Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Domain and Distribution to Stack Outputs #47

Merged
merged 5 commits into from Nov 6, 2017

Conversation

@majones-amplify
Copy link
Contributor

commented Nov 6, 2017

  • Adds the domain name and distribution domain name to the CloudFormation stack outputs under the keys DomainName and DistributionDomainName, same information that we display in the domain summary.
    Closes #43
@aoskotsky-amplify
Copy link
Collaborator

left a comment

Nice

@majones-amplify majones-amplify merged commit 8e61872 into master Nov 6, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@majones-amplify majones-amplify deleted the add_outputs branch Nov 6, 2017

@shaunc

This comment has been minimized.

Copy link

commented Feb 12, 2019

Is there documentation anywhere on Cloudformation outputs? I am trying to use serverless-domain-manager to deploy a nuxt-serverless site, then use the pattern described in serverless doc to deploy the rest api to the same gateway. I need to access the api id and the api root resource id.

@shaunc

This comment has been minimized.

Copy link

commented Feb 12, 2019

How about that -- it turns out the following works! :)

  Outputs:
    apiGatewayRestApiId:
      Value:
        Ref: ApiGatewayRestApi
      Export:
        Name: foo-apiGateway-restApiId
    apiGatewayRestApiRootResourceId:
      Value:
         Fn::GetAtt:
          - ApiGatewayRestApi
          - RootResourceId
      Export:
        Name: foo-apiGateway-rootResourceId

Still, I had to fish for the name "ApiGatewayRestApi" in the source code -- some documentation would be nice.

@captainsidd captainsidd referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.