Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZSH support #19

Merged
merged 11 commits into from
Apr 5, 2020
Merged

ZSH support #19

merged 11 commits into from
Apr 5, 2020

Conversation

sbstp
Copy link
Owner

@sbstp sbstp commented Apr 4, 2020 •
edited

Fixes #18

@pxtxs
Copy link
Contributor

pxtxs commented Apr 4, 2020

What do you think about creating a crate for the detection module ? Instead of implementing the code directly in kubie. Could be useful.

@sbstp
Copy link
Owner Author

sbstp commented Apr 4, 2020

Could be useful indeed. However I don't really want to add support for Windows and more shells. If I publish it on crates.io people might bother me to add support for more shells.

sbstp
sbstp commented Apr 5, 2020
View reviewed changes
src/shell/mod.rs Outdated Show resolved Hide resolved
@sbstp sbstp changed the title WIP: ZSH support ZSH support Apr 5, 2020
@sbstp sbstp merged commit ae17ec6 into master Apr 5, 2020
@sbstp sbstp deleted the support-zsh branch April 5, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZSH support
2 participants
@sbstp @pxtxs