Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable kubie's prompt #23

Merged
merged 2 commits into from Apr 6, 2020
Merged

Add setting to disable kubie's prompt #23

merged 2 commits into from Apr 6, 2020

Conversation

sbstp
Copy link
Owner

@sbstp sbstp commented Apr 6, 2020

@EItanya can you check if this does indeed fix your double prompt issue?

@EItanya
Copy link
Contributor

EItanya commented Apr 6, 2020

Yup, that worked for me! Man you're quick, was about to do that myself this morning.
Hopefully I'm not overstepping here, but I wonder if it would be clearer from a code perspective to not inject the prompt code into the .rc file at all, rather than disabling it with another env var.

For examle something like what I have done here: https://github.com/EItanya/kubie/blob/disable-prompt-non-env/src/shell/zsh.rs

My approach could definitely use cleaning up, but it seems to me that doing this with magic env variables may lead to more confusion down the line.

let me know what you think!

@sbstp
Copy link
Owner Author

sbstp commented Apr 6, 2020

I think you're right. I wanted to do something simple and quick but the zshrc file is quickly getting messy.

@sbstp sbstp merged commit b7213d8 into master Apr 6, 2020
@sbstp sbstp deleted the disable-prompt branch April 6, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants