Feature: Update command #9

pxtxs · 2020-03-06T23:39:31Z

Fixes #7
I'm new to Rust so please review carefully and tell me if it needs any changes.
👍

pxtxs · 2020-03-06T23:40:51Z

@sbstp

src/cmd/update.rs

pxtxs · 2020-03-08T04:04:51Z

@sbstp Thanks for this review. Just did a new commit with some rewriting :)

src/cmd/update.rs

pxtxs · 2020-03-10T14:04:44Z

@sbstp I put this PR on hold for now, I need to change the way I get the latest version to a more reliable way. It wont work as soon as the project reach a 2 digits version number.

src/cmd/update.rs

sbstp · 2020-04-04T16:47:15Z

Cargo.toml

 serde = { version = "1", features = ["derive"] }
+serde_json = "1.0"


Can you change this to "1", semver should protect us from breaking changes.

sbstp · 2020-04-04T16:47:47Z

Cargo.toml

 anyhow = "1"
 atty = "0.2"
 dirs = "2"
 glob = "0.3"
 lazy_static = "1"
 libc = "0.2"
+os_info = "2.0.2"


Can you change this to "2", semver protects us from breaking changes.

sbstp · 2020-04-04T16:48:00Z

Cargo.toml

@@ -13,13 +13,16 @@ license = "Zlib"
 exclude = ["releases/**/*"]

 [dependencies]
+attohttpc = { version = "0.11.1", features = ["json"] }


0.12 is out

sbstp · 2020-04-04T16:56:05Z

I tried out the self update but I have an error:

simon@smith:~/projects/kubie$ target/debug/kubie update
A new version of Kubie is available (v0.7.3), the new version will be automatically installed...
Error: Update failed. Consider using sudo?

Caused by:
    Invalid cross-device link (os error 18)

sbstp · 2020-04-04T17:07:07Z

I did some googling, the error above might be due to renaming across filesystems. We put the downloaded binary in /tmp and then rename it to some other place not in /tmp. /tmp is a special file system.

pxtxs · 2020-04-04T21:24:35Z

Interesting, I did not encounter this error during my tests. I'll check it out.

pxtxs · 2020-04-04T21:32:35Z

@sbstp Could you try to reproduce this issue ? It's working on my MacOS env and in my Linux VM

sbstp · 2020-04-04T21:33:07Z

Yes, I'll check.

sbstp · 2020-04-04T21:36:45Z

simon@smith:~/projects/kubie$ target/debug/kubie update
A new version of Kubie is available (v0.7.3), the new version will be automatically installed...
Error: Update failed. Consider using sudo?

Caused by:
    Text file busy (os error 26)

I think the file must be unlinked/removed before we copy over it.

pxtxs · 2020-04-04T21:48:20Z

I updated the code to remove the file before trying the copy.
You were right about the different filesystems => https://doc.rust-lang.org/src/std/fs.rs.html#1654

sbstp · 2020-04-04T21:56:57Z

It works!

pxtxs · 2020-04-04T21:58:00Z

Be sure to squash lol if we are done with this PR

pxtxs added 3 commits March 6, 2020 18:24

Add update subcommand to get kubie's latest version (only unix)

e76bff5

Remove unwrap unwrap shit and use Result<>

c793f5d

Fix comment

04a3b85

pxtxs added 2 commits March 6, 2020 18:42

cargo fmt

7297457

Update README

a33cb53

sbstp reviewed Mar 7, 2020

View reviewed changes

src/cmd/update.rs Outdated Show resolved Hide resolved

sbstp reviewed Mar 7, 2020

View reviewed changes

src/cmd/update.rs Outdated Show resolved Hide resolved

sbstp reviewed Mar 7, 2020

View reviewed changes

src/cmd/update.rs Outdated Show resolved Hide resolved

sbstp reviewed Mar 7, 2020

View reviewed changes

src/cmd/update.rs Outdated Show resolved Hide resolved

sbstp reviewed Mar 7, 2020

View reviewed changes

src/cmd/update.rs Outdated Show resolved Hide resolved

Downloading kubie to a temporary file and better handling of errors

55d3d8f

sbstp reviewed Mar 8, 2020

View reviewed changes

src/cmd/update.rs Outdated Show resolved Hide resolved

pxtxs and others added 2 commits March 8, 2020 09:36

Remove an useless allocation (PathBuf to string lossy)

ee25121

Use anyhow for error handling during replace file

a965769

pxtxs changed the title ~~Feature: Update command~~ WIP: Feature: Update command Mar 10, 2020

pxtxs added 2 commits April 4, 2020 02:47

Using github release API :) + supporting multi-os

28a9689

Fetching upstream

cfd99ff

pxtxs force-pushed the master branch from cdd2cd6 to cfd99ff Compare April 4, 2020 06:51

pxtxs changed the title ~~WIP: Feature: Update command~~ Feature: Update command Apr 4, 2020

Removing useless print

98d00a7

sbstp reviewed Apr 4, 2020

View reviewed changes

src/cmd/update.rs Outdated Show resolved Hide resolved

sbstp reviewed Apr 4, 2020

View reviewed changes

src/cmd/update.rs Outdated Show resolved Hide resolved

sbstp reviewed Apr 4, 2020

View reviewed changes

src/cmd/update.rs Outdated Show resolved Hide resolved

Some refactoring regarding @sbstp review

3034def

sbstp reviewed Apr 4, 2020

View reviewed changes

Using semver for crates + changing fs::rename to fs::copy

b42cf56

pxtxs force-pushed the master branch from b1e0ad1 to b42cf56 Compare April 4, 2020 21:30

fs::remove_file before the copy

6caa6a0

sbstp merged commit 64b0c1b into sbstp:master Apr 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Update command #9

Feature: Update command #9

pxtxs commented Mar 6, 2020 •

edited

pxtxs commented Mar 6, 2020

pxtxs commented Mar 8, 2020

pxtxs commented Mar 10, 2020

sbstp Apr 4, 2020

sbstp Apr 4, 2020

sbstp Apr 4, 2020

sbstp commented Apr 4, 2020

sbstp commented Apr 4, 2020

pxtxs commented Apr 4, 2020

pxtxs commented Apr 4, 2020

sbstp commented Apr 4, 2020

sbstp commented Apr 4, 2020 •

edited

pxtxs commented Apr 4, 2020

sbstp commented Apr 4, 2020

pxtxs commented Apr 4, 2020 •

edited

		serde = { version = "1", features = ["derive"] }
		serde_json = "1.0"

Feature: Update command #9

Feature: Update command #9

Conversation

pxtxs commented Mar 6, 2020 • edited

pxtxs commented Mar 6, 2020

pxtxs commented Mar 8, 2020

pxtxs commented Mar 10, 2020

sbstp Apr 4, 2020

Choose a reason for hiding this comment

sbstp Apr 4, 2020

Choose a reason for hiding this comment

sbstp Apr 4, 2020

Choose a reason for hiding this comment

sbstp commented Apr 4, 2020

sbstp commented Apr 4, 2020

pxtxs commented Apr 4, 2020

pxtxs commented Apr 4, 2020

sbstp commented Apr 4, 2020

sbstp commented Apr 4, 2020 • edited

pxtxs commented Apr 4, 2020

sbstp commented Apr 4, 2020

pxtxs commented Apr 4, 2020 • edited

pxtxs commented Mar 6, 2020 •

edited

sbstp commented Apr 4, 2020 •

edited

pxtxs commented Apr 4, 2020 •

edited