This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Update parsing.rs #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the code, specifically parsing.rs on line 53 a check is made for urn:schemas-upnp-org:service:WANIPConnection:1, the closest thing I have in my xml is urn:schemas-upnp-org:service:WANPPPConnection1 and changing it to that gets the example to run. I don't really have much experience with networking but all routers in South Africa use PPP as far as I know, perhaps I could open a pull request to check for either of the above and use the appropriate one?
|
Looks good, thanks! |
|
I'll release this ASAP as a non-breaking version bump, so |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the below changes resulted in the examples running for me, I tested the code before the changes and it failed on about 3 different routers. Hopefully this will allow it to work on most routers in South Africa ( or any other country which uses PPP ).
See #38 for more information