use \n for line endings #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having platfrom dependent line endings makes contraband behave platform dependently. That's undesirable for reproducibility
|
If we used |
|
I guess this would create large diffs once for repos that only use windows both on local machines and CI. While I suspect that to be uncommon, I can't be sure. If they should look the same as coded by hand, that's going to differ from person to person. I don't think many people use \r\n. Perhaps the line end should align with the most commonly used line end in the contraband file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having platform-dependent line endings makes contraband behave platform dependently. That's undesirable for reproducibility and problematic in cases where contraband output is part of some VCS where people on different platforms collaborate.
fixes #122