Add maxSocketLength to native api #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eatkins you missed binary for |
|
No. It builds a fat binary now with both arm64 and x86_64. |
Downstream consumers, e.g. sbt, may need to know the maximum size of the unix socket address to avoid adding an invalid value. We can expose this through the UnixDomainSocketLibraryProvider which has JNI and JNA implementations.
|
Once this is in, it should be a straightforward change at https://github.com/sbt/sbt/blob/3a7ab8cf5eca4d1e064dd1b198eb7757be2f4ec2/main-command/src/main/scala/sbt/internal/server/Server.scala#L74 to get full arm64 support server side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream consumers, e.g. sbt, may need to know the maximum size of the
unix socket address to avoid adding an invalid value. We can expose this
through the UnixDomainSocketLibraryProvider which has JNI and JNA
implementations.