Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try meven-metadata-local.xml. Fixes sbt/ivy#20 #21

Merged
merged 2 commits into from
Dec 30, 2015

Conversation

eed3si9n
Copy link
Member

eed3si9n added a commit to sbt/sbt that referenced this pull request Dec 30, 2015
@@ -191,7 +191,34 @@ public void endElement(String uri, String localName, String qName)

return rev;
}
} else {
} else if (root.startsWith("file:")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why file:?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file:// indicates that the repo is local.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inferring from this that maven-metadata-local.xml is only a thing in local repos. Sorry, not a part of maven repos that I knew about.

@dwijnand
Copy link
Member

Couple of questions, particularly the "file:" one, other than that LGTM

eed3si9n added a commit that referenced this pull request Dec 30, 2015
Try meven-metadata-local.xml. Fixes #20
@eed3si9n eed3si9n merged commit 89704c7 into 2.3.x-sbt Dec 30, 2015
@eed3si9n eed3si9n deleted the wip/localmetadata branch December 30, 2015 12:05
Duhemm pushed a commit to Duhemm/sbt that referenced this pull request Feb 1, 2016
eed3si9n added a commit to eed3si9n/sbt that referenced this pull request Feb 26, 2016
eed3si9n added a commit to eed3si9n/sbt that referenced this pull request Feb 26, 2016
eed3si9n added a commit to eed3si9n/sbt that referenced this pull request Feb 27, 2016
eed3si9n added a commit to eed3si9n/sbt that referenced this pull request Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants