-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try meven-metadata-local.xml. Fixes sbt/ivy#20 #21
Conversation
@@ -191,7 +191,34 @@ public void endElement(String uri, String localName, String qName) | |||
|
|||
return rev; | |||
} | |||
} else { | |||
} else if (root.startsWith("file:")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why file:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file://
indicates that the repo is local.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inferring from this that maven-metadata-local.xml
is only a thing in local repos. Sorry, not a part of maven repos that I knew about.
Couple of questions, particularly the "file:" one, other than that LGTM |
Try meven-metadata-local.xml. Fixes #20
Ref sbt/sbt#1616
/review @dwijnand, @Duhemm, @jsuereth