Set explicit HTTP Accept header to avoid text/html

[3rwww1]

By default, java.net.HttpURLConnection HTTP Accept header is set to text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2

This leads to Microsoft servers responding with a 203 status code and an HTML pages when uploading or downloading artifacts to Azure Artifacts.

Given that Maven also have a similar issue (text/html as the preferred response content-type), Microsoft has implemented a workaround that ignores the Accept header values when User-Agent is Apache Maven/*. However, this workaround is not implemented on their side for SBT.

This pull request sets HTTP Accept header to application/octet-stream, application/json, application/xml, */* to fix this behavior, as evidenced here:

https://dev.azure.com/aironek/sbt-test/_build/results?buildId=43&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=b60649db-91ed-45ce-b0dd-c9633ee87772

Given that the last component is */*, this shoud be backward-compatible with other serivces (Nexus, Artifactory, etc) that reply with different content-types.

[3rwww1]

see sbt/sbt#5483

[eed3si9n]

Thanks!

[dwijnand]

This leads to Microsoft servers responding with a 203 status code and an HTML pages when uploading or downloading artifacts to Azure Artifacts.

Does that mean it fixes sbt/sbt#5492 too, @3rwww1?

[milanvdm]

@dwijnand Ever got a response to your question? :)

[dwijnand]

No. But I'm leaning towards yes, because more often than not you hear back when it's still broken... 🙂

[eed3si9n]

Re: sbt/sbt#5492, the issue is mostly about being able to resolve artifacts out of Azure DevOps Maven, so maybe tweaking Ivy might help for ThisBuild / useCoursier := false case, but as a general issue it would likely need coursier/coursier#1649.

[3rwww1]

@dwijnand unfortunately I'm still not sure, I'm still jury-rigging around the issue with ThisBuild / useCoursier := false

I'll try and test with coursier when I have some free time, I guess that all coursier need is to "set Accept: header to something other than text/html", as per MS dev team instructions. Don't know if coursier does set those headers properly though, last time I checked it seemed it didn't.