InlineConfiguration is renamed to ModuleConfiguration but doesn't extend ModuleSettings #154
Labels
uncategorized
Used for Waffle integration
Comments
muuki88
added a commit
to sbt/sbt-native-packager
that referenced
this issue
Aug 6, 2017
|
haha. It's a documentation bug. |
muuki88
added a commit
to sbt/sbt-native-packager
that referenced
this issue
Aug 7, 2017
muuki88
added a commit
to sbt/sbt-native-packager
that referenced
this issue
Aug 10, 2017
* Cross build with sbt 1.0 * Fix travis.yml * Fix Build.scala scripted tests * Remove 'provided' scope for jdeb temporarily * Fix dependencies for scripted tests * Fix scripted test calls by using packageBin instead of package-bin * Fix multiproject-classifiers test by using new `withClassifier` method. This may break 0.13.6 -> add compat for this * Replace all *** PathFilter calls in scripted tests * Replace Process with sys.process.Process and add Compat.io import * Fixing all remaining scripted tests * Fix jdk-packager script tests * Fix travis osx oraclejdk8 issue: travis-ci/travis-ci/issues/2316 * Reduce travis ci test matrix * Update out-dated akka dependency in scripted test * Replace akka with typesafe config as a dependency test We need a stable library for scala 2.10 and 2.12. A java lib is more suitable here. * Fix wrong task names * Replace akka with typesafe config as a dependency test We need a stable library for scala 2.10 and 2.12. A java lib is more suitable here. * Polyfill new method `withClassifier` on sbt.Artifact * Remove jdk definition * List every test setup explicitly for travis * Also set env for the osx build * Only use java8 for testing and output scripted buffer * Another approach for travis * Fix rpm scripted tests * Rebase and fix newly added test * Fix debian scripted tests * Run only the script docker tests which don't require docker * Fix validateJdkPackager and actually run the jdkpackacker scripts * Explicitly include all the different envs in travis * Remove jdkpackager/test-package-image scripted test on travis * Upgrade to sbt-1.0.0-RC2 and use crossbuil * Go back to M6 and switch-case the provided dependencies * Run actual tests on MacOS X * use sbtVersion in pluginCrossBuild and downgrade to sbt-io M11 * Fix scripted camelCase jdkpackager * Try to upgrade to 1.0.0-RC2 * Build with 0.13.16 * Upgrade sbt-io * Fix linting error for ivy configs * Upgrade to 1.0.0-RC3 * Fix jar names in JavaAppPackaging. See sbt/sbt/issues/3388 * Formatting SettingsHelper * Adding the correct moduleSettings See sbt/librarymanagement/issues/154 * Upgrade scalafmt * Upgrade sbt-release process * Setting version to 1.2.2-RC1 * Setting version to 1.2.2-SNAPSHOT
|
Not sure if this is still relevant. Closing this for now. |
littleRoundaer
added a commit
to littleRoundaer/sbt-native-packager
that referenced
this issue
Jul 19, 2022
* Cross build with sbt 1.0 * Fix travis.yml * Fix Build.scala scripted tests * Remove 'provided' scope for jdeb temporarily * Fix dependencies for scripted tests * Fix scripted test calls by using packageBin instead of package-bin * Fix multiproject-classifiers test by using new `withClassifier` method. This may break 0.13.6 -> add compat for this * Replace all *** PathFilter calls in scripted tests * Replace Process with sys.process.Process and add Compat.io import * Fixing all remaining scripted tests * Fix jdk-packager script tests * Fix travis osx oraclejdk8 issue: travis-ci/travis-ci/issues/2316 * Reduce travis ci test matrix * Update out-dated akka dependency in scripted test * Replace akka with typesafe config as a dependency test We need a stable library for scala 2.10 and 2.12. A java lib is more suitable here. * Fix wrong task names * Replace akka with typesafe config as a dependency test We need a stable library for scala 2.10 and 2.12. A java lib is more suitable here. * Polyfill new method `withClassifier` on sbt.Artifact * Remove jdk definition * List every test setup explicitly for travis * Also set env for the osx build * Only use java8 for testing and output scripted buffer * Another approach for travis * Fix rpm scripted tests * Rebase and fix newly added test * Fix debian scripted tests * Run only the script docker tests which don't require docker * Fix validateJdkPackager and actually run the jdkpackacker scripts * Explicitly include all the different envs in travis * Remove jdkpackager/test-package-image scripted test on travis * Upgrade to sbt-1.0.0-RC2 and use crossbuil * Go back to M6 and switch-case the provided dependencies * Run actual tests on MacOS X * use sbtVersion in pluginCrossBuild and downgrade to sbt-io M11 * Fix scripted camelCase jdkpackager * Try to upgrade to 1.0.0-RC2 * Build with 0.13.16 * Upgrade sbt-io * Fix linting error for ivy configs * Upgrade to 1.0.0-RC3 * Fix jar names in JavaAppPackaging. See sbt/sbt/issues/3388 * Formatting SettingsHelper * Adding the correct moduleSettings See sbt/librarymanagement/issues/154 * Upgrade scalafmt * Upgrade sbt-release process * Setting version to 1.2.2-RC1 * Setting version to 1.2.2-SNAPSHOT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
While fixing the
SettingsHelperto be compatible with1.xI was confused by the 1.0.0 notes. It statesIn the
0.13.xSettingsHelperI have this linewhich I tried to turn into
The issue was that
ModuleConfigurationdoesn't extendModuleSettings. HoweverModuleDescriptorConfigurationdoes and seems to work:I'm not familiar enough with the ivy module implementation details to tell if this is a documentation bug, an implementation bug or if I'm doing something wrong ;)
The text was updated successfully, but these errors were encountered: