Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file name to exception message #171

Merged
merged 1 commit into from Sep 26, 2017
Merged

Add file name to exception message #171

merged 1 commit into from Sep 26, 2017

Conversation

leonardehrenfried
Copy link
Contributor

I'm currently running into the error described here: sbt/sbt#3431

This PR adds more information to the error message so debugging is at least possible.

@typesafe-tools
Copy link

The validator has checked the following projects against Scala 2.12, 2.10,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt 1.x sbt/sbt@9d8a041
zinc 1.x sbt/zinc@b63e9c6
io 1.x sbt/io@62004b2
librarymanagement pull/171/head 08fedf7
util 1.x sbt/util@be73dc0
website 1.x

❌ The result is: FAILED
(restart)

@leonardehrenfried
Copy link
Contributor Author

The Travis build fails with

[info] ModuleResolversTest:
[info] The direct resolvers in update options
[info] - should skip the rest of resolvers *** FAILED ***
[info]   605 was not less than or equal to 581.6 (ModuleResolversTest.scala:48)

Is this something introduced by this commit?

@dwijnand
Copy link
Member

Nope.

@eed3si9n eed3si9n changed the base branch from 1.x to 1.0.x September 26, 2017 22:42
@eed3si9n
Copy link
Member

Changed based to 1.0.x.

@eed3si9n eed3si9n merged commit eda1e77 into sbt:1.0.x Sep 26, 2017
eed3si9n added a commit to eed3si9n/librarymanagement that referenced this pull request Jul 29, 2018
Fixes sbt/sbt#3431
Fixes sbt/sbt#4275

sbt#171 attempted to fix the error message previously, but it was not handling the common cases where the put is delegated to `super.put(...)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants