Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat with scalafmt #87

Merged
merged 2 commits into from Apr 26, 2017
Merged

Reformat with scalafmt #87

merged 2 commits into from Apr 26, 2017

Conversation

jvican
Copy link
Member

@jvican jvican commented Apr 25, 2017

Same as sbt/sbt#3125.

@eed3si9n eed3si9n added the ready label Apr 25, 2017
build.sbt Outdated
@@ -56,6 +56,13 @@ lazy val lm = (project in file("librarymanagement")).
val sdirs = (managedSourceDirectories in Compile).value
val base = baseDirectory.value
(((srcs --- sdirs --- base) pair (relativeTo(sdirs) | relativeTo(base) | flat)) toSeq)
},
commands += Command.command("scalafmtCheck") { state =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add this to the root (lmRoot)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jvican
Copy link
Member Author

jvican commented Apr 26, 2017

I have updated the formatting of all the sources here. Right now, we strictly follow what upstream sbt does. Do you mind having a look @eed3si9n ?

@eed3si9n
Copy link
Member

LGTM

@jvican
Copy link
Member Author

jvican commented Apr 26, 2017

Since this is just a port of sbt/sbt reformatting, there's already a signoff and CI is green, can we merge this and I rebase #88?

@eed3si9n eed3si9n merged commit c588869 into sbt:1.0 Apr 26, 2017
@eed3si9n eed3si9n removed the ready label Apr 26, 2017
jvican added a commit to scalacenter/zinc that referenced this pull request May 3, 2017
eed3si9n pushed a commit to scala/compiler-interface that referenced this pull request Apr 23, 2019
dwijnand pushed a commit to dwijnand/sbt that referenced this pull request Apr 25, 2019
eed3si9n pushed a commit to eed3si9n/scala that referenced this pull request May 14, 2019
lrytz pushed a commit to lrytz/scala that referenced this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants