Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't unzip the jars (maven-assembly-plugin mode) #12

Closed
eed3si9n opened this issue Aug 5, 2011 · 1 comment
Closed

don't unzip the jars (maven-assembly-plugin mode) #12

eed3si9n opened this issue Aug 5, 2011 · 1 comment

Comments

@eed3si9n
Copy link
Member

eed3si9n commented Aug 5, 2011

originally reported by @rollinsruss

steps

  1. add deps to "org.jboss.netty" % "netty" % "3.2.3.Final, spring etc.
  2. assembly

problem

the license folder, *.handlers, etc gets wiped out under META-INF.

expectation

That being said, I keep coming back to thinking about the Maven assembly plugin that applies an alternative approach to unzipping everything and simply shoves the jars into an embedded lib directory and updates the manifest so the classpath is complete--which avoids this problem altogether and maintains pristine isolation. Perhaps that approach could be a future alternative task on this plugin (wish I had time to help, as it has me quite intrigued).

@eed3si9n
Copy link
Member Author

This is more complicated than I thought (requires custom class loader), and there's sbt-one-jar that does it already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant