Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on Windows #471

Merged
merged 6 commits into from
Oct 5, 2022
Merged

Run CI on Windows #471

merged 6 commits into from
Oct 5, 2022

Conversation

nightscape
Copy link

I'm noticing an error on Windows for 2.0.0-RC1 which was not there under 1.2.0 (will create a ticket for that).
As a first step for fixing this it would be good if the CI discovered and exposed the error.
I'm hoping that adding Windows to the build matrix already does so.

@nightscape
Copy link
Author

nightscape commented Jun 23, 2022

@eed3si9n this PR would be ready to squash-merge from my side. It exposes the Windows bug in #472
What is not clear is if the Windows CI build would succeed if the bug was fixed.
In order to test that, one would probably have to run the Windows CI against version 1.2.0 which is not affected by the bug.
Any recommendations on how to proceed here?

@eed3si9n
Copy link
Member

Any recommendations on how to proceed here?

I just created a branch called 1.x out of 1.2.0 - https://github.com/sbt/sbt-assembly/tree/1.x
You could send another PR if you would like against it.

@nightscape
Copy link
Author

Done in #473
Once that PR builds correctly on Windows, we can move on with this one here.

This was referenced Oct 4, 2022
@eed3si9n eed3si9n merged commit 1a529bc into sbt:develop Oct 5, 2022
@nightscape nightscape deleted the patch-1 branch October 6, 2022 00:16
@fnqista
Copy link

fnqista commented Oct 17, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants