Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning compatibility with ivy2/maven wildcard patterns for first snapshot build after tag #52

Closed
lokkju opened this issue Dec 7, 2017 · 2 comments · Fixed by #63

Comments

@lokkju
Copy link

lokkju commented Dec 7, 2017

I'm loving this plugin, but I'm looking for a way to easily use it with dependency wildcard patterns in ivy and maven.

the current versioning pattern means that the first "snapshot" version after a tag is 0.0.1+20171207-1200 ; while the first committed version after a tag is 0.0.1+1-01234abcd

This means that a version spec like "0.0.1+" will select the older, snapshot, version over the newer version.

This could be solved just by changing the first snapshot build after a tag to use 0.0.1+0+20171207-1200

I know I can customize my version string - but this seems like a wide use case.

@dwijnand
Copy link
Member

dwijnand commented Dec 7, 2017

Interesting.

Here are the relevant cases:

1.0.0+20140707-1030
1.0.0+3-1234abcd
1.0.0+3-1234abcd+20140707-1030

Perhaps we can change that first one so it's:

1.0.0+0-00000000-20140707-1030
1.0.0+3-1234abcd
1.0.0+3-1234abcd+20140707-1030

@lokkju
Copy link
Author

lokkju commented Dec 7, 2017

Yup, that should work perfectly.

leonardehrenfried added a commit to leonardehrenfried/sbt-dynver that referenced this issue Feb 17, 2018
leonardehrenfried added a commit to leonardehrenfried/sbt-dynver that referenced this issue Feb 25, 2018
dwijnand pushed a commit that referenced this issue Feb 27, 2018
Use 'git describe --long' to get SHA1 on dirty tag.

Fixes #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants