Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaData and Pre-Release Order Incorrect #93

Closed
apeschel opened this issue Mar 19, 2019 · 2 comments
Closed

MetaData and Pre-Release Order Incorrect #93

apeschel opened this issue Mar 19, 2019 · 2 comments

Comments

@apeschel
Copy link

apeschel commented Mar 19, 2019

DynVer currently produces SemVer-ish, but invalid versions with the pre-release and metadata fields reversed.

As per the SemVer spec, the order should be

<version core> "-" <pre-release> "+" <build>
@dwijnand
Copy link
Member

This is intentional. SemVer only has pre-release modifiers and has no way to convey post-release versions. There are a few threads in the SemVer spec repo where I (along with some others) try and request support for this (to no success).

Given - is the separator for pre-release, + is (IMO) a good separator for post-release, thus 1.0.0+3-1234abcd.

Contrary to the SemVer spec, the information in + segment is not build information and it is relevant to version precendence (1.0.0+3-1234abcd is not the same as 1.0.0+2-3452afed).

Do you think it would be an improvment to mention this in the README, or do you think it's a niche concern?

@apeschel
Copy link
Author

apeschel commented Mar 19, 2019

@dwijnand Probably worth mentioning in the README, since the examples seem to imply an attempt at compatibility with SemVer, so the intentional divergence is of worthy note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants