Update README to specify tag requirements #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
requested changes
Jan 24, 2017
| ## Tag Requirements | ||
|
|
||
| In order to be recognized by sbt-dynver, tags must meet the following two requirements: | ||
| 1. Must be an annotated tag (as opposed to a lightweight tag) |
|
|
||
| In order to be recognized by sbt-dynver, tags must meet the following two requirements: | ||
| 1. Must be an annotated tag (as opposed to a lightweight tag) | ||
| 2. Must begin with the letter 'v' |
There was a problem hiding this comment.
Let's be really specific :) It must begin with the letter 'v' and a digit: v[0-9].
|
|
||
| If you're not seeing what you expect, then start with this: | ||
|
|
||
| git tag -af v0.0.1 -m "Initial version tag for sbt-dynver" |
There was a problem hiding this comment.
Real, real nitpick: could you drop the -f :)
There was a problem hiding this comment.
I'll make these revisions, no problem. Thanks for the additional detail.
dwijnand
approved these changes
Jan 24, 2017
|
Thanks @MartinSnyder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dale,
Didn't take me long to figure this out, but I thought I'd leave this breadcrumb for future users so they don't get confused about how to get sbt-dynver to recognize tags.