Fix dynverAssertTagVersion #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** dynverAssertTagVersion currently throws NPE. ``` [info] [info] Loading settings from plugins.sbt ... [info] [info] Loading project definition from /.../assert-tag-version-ok/project [info] [info] Loading settings from build.sbt ... [info] [error] java.lang.NullPointerException [info] [error] at sbt.internal.util.Init$$anon$11.apply(Settings.scala:690) [info] [error] at sbt.internal.util.Init$$anon$11.apply(Settings.scala:690) [info] [error] at sbt.internal.util.AList$$anon$6.transform(AList.scala:102) [info] [error] at sbt.internal.util.AList$$anon$6.transform(AList.scala:100) [info] [error] at sbt.internal.util.Init$Apply.mapInputs(Settings.scala:837) [info] [error] at sbt.internal.util.Init$Apply.mapReferenced(Settings.scala:832) [info] [error] at sbt.internal.util.Init$Setting.mapReferenced(Settings.scala:599) [info] [error] at sbt.Project$.$anonfun$transform$1(Project.scala:530) ``` **Solution** Make things lazy to fix the bug. Co-authored-by: Matthias Kurz <m.kurz@irregular.at> Co-authored-by: eugene yokota <eed3si9n@gmail.com>
mkurz
approved these changes
May 1, 2023
| version := { | ||
| val orig = version.value | ||
| if (orig.endsWith("-SNAPSHOT")) "5.0.1-SNAPSHOT" | ||
| else orig |
There was a problem hiding this comment.
Side note: I see what you did here. Actually there is an closed issue you might be interested in: #227
In Play we came up with a more dynamic solution for now:
- https://github.com/playframework/playframework/blob/main/build.sbt#L25-L33
- https://github.com/playframework/playframework/blob/982639c0287812d251cda7942017bf646fdf319f/project/VersionHelper.scala
IMHO setting the version to the next major/minor/patch release (snapshot) version should be a feature of sbt-dynver. Haven't had time yet to come up with a pr however...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254
Ref #252 /cc @mkurz
Problem
dynverAssertTagVersion currently throws NPE.
Solution
Make things lazy to fix the bug.