Ability to choose license type via license argument has been added.
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -349,22 +226,7 @@ private object Template { | |||
| def `package`(packageSegments: Vector[String], author: String): String = { | |||
| val superPackage = packageSegments.init.mkString(".") | |||
| val lastSegment = packageSegments.last | |||
| s"""|/* | |||
There was a problem hiding this comment.
Header part has been removed from Template because sbt-header anyway will add it to final project at first compilation.
| @@ -20,7 +20,7 @@ import java.nio.charset.StandardCharsets.UTF_8 | |||
| import java.nio.file.{ Files, Path } | |||
| import org.eclipse.jgit.api.Git | |||
|
|
|||
| private class Fresh(buildDir: Path, organization: String, name: String, author: String) { | |||
| private class Fresh(buildDir: Path, organization: String, name: String, author: String, licenseKind: String) { | |||
|
Nice! Just a few comments wrt code style. |
|
Thanks for review - I will fix that. |
|
@hseeberger |
|
Thanks, @strobe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See updates at README for details.
Default choose still an Apache license.
This implementation depends on snapshot version of sbt-header plugin (commit hash: 7045c0afc1724106b83766d3ae3ce31a5ef18acd), which is published to Bintray by me.
Therefore it's looks like we have to wait till next release of sbt-header before do merge,
but I think is great to have some extra time to review this PR.
Thanks.