Add useReachableTags setting to allow searching beyond HEAD for tag matching.
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @oliverlockwood, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
@lightbend-cla-validator I have now signed the license agreement. |
oliverlockwood
force-pushed
the
use-reachable-tags
branch
from
3889272
to
2999445
Compare
|
Is anyone actually looking at PRs on this project? I raised this over 4 months ago and it's been silent. |
|
Closing this as a PR I'm about to raise supersedes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #93.
This is very much thrown up "for discussion" rather than necessarily expecting it to be implemented in its current form.
Particularly, it's currently quite inefficient as it involves checking all tags against all parent commits of HEAD. But I thought the configuration interface (and whether or not the functionality is acceptable at all!) could be discussed before the implementation is optimised.