This repository has been archived by the owner on Apr 25, 2021. It is now read-only.

Fix --jvm-debug not working on Windows #321

Merged

eed3si9n merged 3 commits into sbt:master from XenonAbe:sbtIssue5223

Mar 4, 2020

Contributor

XenonAbe commented Mar 3, 2020 •

edited by eed3si9n

Fixes sbt/sbt#5223


          Fix --jvm-debug not working on Windows

8143bbf

Member

eed3si9n commented Mar 3, 2020

@XenonAbe Thanks for the contribution! Could you add a test here please? https://github.com/sbt/sbt-launcher-package/blob/master/integration-test/src/test/scala/RunnerTest.scala

XenonAbe added 2 commits

March 4, 2020 11:48


          Fix --verbose output with --jvm-debug on Windows

bcf5f02


          Add test for --jvm-debug

Contributor Author

XenonAbe commented Mar 4, 2020

I added a test and tested on...

Windows 10 with Java 8
macOS Catalina with Java 8

eed3si9n approved these changes

View reviewed changes

Member

eed3si9n left a comment

Thanks!

eed3si9n merged commit 25c1b96 into sbt:master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.